Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22926002: Report DEFAULT_VALUE_IN_FUNCTION_TYPE_PARAMETER. (Closed)

Created:
7 years, 4 months ago by scheglov
Modified:
7 years, 4 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Report DEFAULT_VALUE_IN_FUNCTION_TYPE_PARAMETER. Also triage the test that was initially marked with this issue, but now is not. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=26025

Patch Set 1 #

Total comments: 2

Messages

Total messages: 3 (0 generated)
scheglov
7 years, 4 months ago (2013-08-12 19:45:06 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/22926002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java File editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java (right): https://codereview.chromium.org/22926002/diff/1/editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java#newcode2497 editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:2497: * This verifies that the given default formal ...
7 years, 4 months ago (2013-08-12 19:50:28 UTC) #2
scheglov
7 years, 4 months ago (2013-08-12 19:56:15 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r26025 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698