Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229183002: Include PUB_CACHE when invoking build.dart too. (Closed)

Created:
6 years, 8 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 8 months ago
Reviewers:
ricow1, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Include PUB_CACHE when invoking build.dart too. R=whesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34843

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M pkg/pkgbuild.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Siggi Cherem (dart-lang)
6 years, 8 months ago (2014-04-08 20:57:35 UTC) #1
Bill Hesse
lgtm
6 years, 8 months ago (2014-04-08 21:02:00 UTC) #2
Siggi Cherem (dart-lang)
Committed patchset #1 manually as r34843 (presubmit successful).
6 years, 8 months ago (2014-04-08 21:09:46 UTC) #3
ricow1
6 years, 8 months ago (2014-04-09 07:54:38 UTC) #4
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698