Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 22918023: Polish the removal of EventHandler cleanup in r26517. (Closed)

Created:
7 years, 4 months ago by Anders Johnsen
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Ivan Posva
Visibility:
Public.

Description

Polish the EventHandler cleanup in r26517. BUG= R=iposva@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=27386

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M runtime/bin/eventhandler_android.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/eventhandler_linux.cc View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/bin/eventhandler_macos.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Anders Johnsen
7 years, 4 months ago (2013-08-23 05:16:42 UTC) #1
Søren Gjesse
lgtm
7 years, 4 months ago (2013-08-23 08:48:10 UTC) #2
Ivan Posva
LGTM and thanks for the cleanup. -Ivan
7 years, 4 months ago (2013-08-23 19:14:07 UTC) #3
Anders Johnsen
7 years, 3 months ago (2013-09-11 15:31:54 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r27386 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698