Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 22914028: Update test for assignment to final variables (Closed)

Created:
7 years, 4 months ago by Søren Gjesse
Modified:
7 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, kustermann
Visibility:
Public.

Description

Update test for assignment to final variables The latest spec (0.51) says: Attempting to assign to a final variable anywhere except in its declaration or in a constructor header will cause a runtime error to be thrown as discussed below. The assignment will also give rise to a static warning. R=ahe@google.com BUG=7062, 11591 Committed: https://code.google.com/p/dart/source/detail?r=26519

Patch Set 1 #

Patch Set 2 : Removed final_var_negative_test.dart #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -34 lines) Patch
D tests/language/final_var_negative_test.dart View 1 1 chunk +0 lines, -10 lines 0 comments Download
M tests/language/final_variable_assignment_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/language/language.status View 1 chunk +0 lines, -6 lines 0 comments Download
M tests/language/language_analyzer.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 1 chunk +0 lines, -5 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Søren Gjesse
7 years, 4 months ago (2013-08-22 12:38:15 UTC) #1
Søren Gjesse
Updated the CL with removal of final_var_negative_test.dart as it does not test anything not already ...
7 years, 4 months ago (2013-08-22 12:50:31 UTC) #2
ahe
lgtm AWESOME!
7 years, 4 months ago (2013-08-22 13:03:55 UTC) #3
Søren Gjesse
7 years, 4 months ago (2013-08-22 13:15:32 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r26519 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698