Issue 22912004: Initial Dartium custom element support

Issue 22912004: Initial Dartium custom element support (Closed)

Created:
7 years, 4 months ago by vsm

Modified:
7 years, 4 months ago

Reviewers:
blois

CC:
reviews_dartlang.org, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Initial Dartium custom element support This will need to be rebased with Stephen's CL or vice versa. The test mod is taken from his CL. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=26141

Patch Set 1 #

Patch Set 2 : Revert parser hack #

Total comments: 2

Patch Set 3 : Add more lifecycle testing #

Patch Set 4 : Remove debug print #

Patch Set 5 : Mark tests fail until parser fix #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+80 lines, -0 lines)			Patch
M	tests/html/custom_elements_test.dart	View	1 2	2 chunks	+31 lines, -0 lines	0 comments	Download
M	tests/html/html.status	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1 2 3	1 chunk	+32 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/dartium/html_dartium.darttemplate	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tools/dom/templates/html/impl/impl_HTMLDocument.darttemplate	View		1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

blois

lgtm https://codereview.chromium.org/22912004/diff/3001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/22912004/diff/3001/tools/dom/src/native_DOMImplementation.dart#newcode219 tools/dom/src/native_DOMImplementation.dart:219: print('testing ${superClass.simpleName.toString()}'); Debug code

7 years, 4 months ago (2013-08-13 17:15:44 UTC) #2

vsm

Expanded tests. PTAL. https://codereview.chromium.org/22912004/diff/3001/tools/dom/src/native_DOMImplementation.dart File tools/dom/src/native_DOMImplementation.dart (right): https://codereview.chromium.org/22912004/diff/3001/tools/dom/src/native_DOMImplementation.dart#newcode219 tools/dom/src/native_DOMImplementation.dart:219: print('testing ${superClass.simpleName.toString()}'); On 2013/08/13 17:15:44, blois ...

7 years, 4 months ago (2013-08-13 19:23:30 UTC) #3

vsm

7 years, 4 months ago (2013-08-14 19:47:13 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r26141 (presubmit successful).

Expand Messages | Collapse Messages