Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(251)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 22909059: Some more removals of dart:utf. (Closed)

Created:
7 years, 3 months ago by floitsch
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org, nweiz, Bob Nystrom, Jennifer Messerly, ahe
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : Undo dart:utf removal in the mini-parser. #

Patch Set 4 : Remove utf-package dependency in barback and rebase. #

Total comments: 2

Patch Set 5 : Change ArgumentError to FormatException. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -51 lines) Patch
M pkg/barback/lib/src/asset.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/barback/test/asset_test.dart View 1 2 3 5 chunks +8 lines, -9 lines 0 comments Download
M pkg/csslib/test/compiler_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/csslib/test/nested_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/csslib/test/var_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/csslib/test/visitor_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/http/lib/src/multipart_request.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/http/test/multipart_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/file_system/console.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/scheduled_test/lib/src/descriptor/file_descriptor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/source_maps/lib/printer.dart View 2 chunks +1 line, -2 lines 0 comments Download
M pkg/source_maps/lib/span.dart View 2 chunks +1 line, -2 lines 0 comments Download
M runtime/bin/vmservice/vmservice.dart View 1 chunk +0 lines, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/source_file_provider.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart View 1 2 3 4 2 chunks +4 lines, -6 lines 0 comments Download
M tests/corelib/uri_test.dart View 2 chunks +2 lines, -2 lines 2 comments Download
M tests/standalone/debugger/debug_lib.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/io/test_runner_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/standalone/vmservice/test_helper.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tools/coverage.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/ddbg.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tools/testing/dart/android.dart View 1 chunk +0 lines, -1 line 0 comments Download
M utils/lib/file_system_vm.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
floitsch
I have started removing dart:utf imports. Please check in particular that the strict behavior of ...
7 years, 3 months ago (2013-08-26 18:21:15 UTC) #1
floitsch
Undid the dart:utf removal for the mini-parser.
7 years, 3 months ago (2013-08-26 18:27:37 UTC) #2
floitsch
Had wrong base. sorry. Also removed barback dependency to package:utf.
7 years, 3 months ago (2013-08-26 18:36:48 UTC) #3
Jennifer Messerly
polymer change LGTM. do we also need to change "pkg/third_party/html5lib"? I noticed a few files ...
7 years, 3 months ago (2013-08-26 19:19:22 UTC) #4
nweiz
Barback, http, and scheduled_test stuff lgtm.
7 years, 3 months ago (2013-08-26 20:46:47 UTC) #5
nweiz
https://codereview.chromium.org/22909059/diff/10001/sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart File sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart (right): https://codereview.chromium.org/22909059/diff/10001/sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart#newcode27 sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart:27: } on ArgumentError catch (_) { Isn't this now ...
7 years, 3 months ago (2013-08-26 20:48:00 UTC) #6
floitsch
https://codereview.chromium.org/22909059/diff/10001/sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart File sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart (right): https://codereview.chromium.org/22909059/diff/10001/sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart#newcode27 sdk/lib/_internal/pub/lib/src/validator/utf8_readme.dart:27: } on ArgumentError catch (_) { On 2013/08/26 20:48:00, ...
7 years, 3 months ago (2013-08-26 21:46:59 UTC) #7
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/22909059/diff/16001/tests/corelib/uri_test.dart File tests/corelib/uri_test.dart (right): https://codereview.chromium.org/22909059/diff/16001/tests/corelib/uri_test.dart#newcode208 tests/corelib/uri_test.dart:208: var s = UTF8.decode([0xf0, 0x90, 0x80, 0x80]); Why ...
7 years, 3 months ago (2013-08-27 09:22:42 UTC) #8
floitsch
https://codereview.chromium.org/22909059/diff/16001/tests/corelib/uri_test.dart File tests/corelib/uri_test.dart (right): https://codereview.chromium.org/22909059/diff/16001/tests/corelib/uri_test.dart#newcode208 tests/corelib/uri_test.dart:208: var s = UTF8.decode([0xf0, 0x90, 0x80, 0x80]); On 2013/08/27 ...
7 years, 3 months ago (2013-08-27 09:33:58 UTC) #9
floitsch
7 years, 3 months ago (2013-08-27 13:19:01 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 manually as r26712 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698