Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issue 22909032: Fix allocation of indices for try-blocks. (Closed)

Created:
7 years, 4 months ago by Florian Schneider
Modified:
7 years, 4 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix allocation of indices for try-blocks. The compiler has the assumptions that try-index starts at zero for each function: The list of exception handlers is a dense array indexed using the try-index. BUG=https://code.google.com/p/dart/issues/detail?id=12615 TEST=tests/language/regress_12615_test.dart R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26585

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M runtime/vm/parser.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/parser.cc View 4 chunks +8 lines, -2 lines 0 comments Download
A tests/language/regress_12615_test.dart View 1 chunk +14 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Florian Schneider
7 years, 4 months ago (2013-08-22 13:51:04 UTC) #1
srdjan
lgtm https://codereview.chromium.org/22909032/diff/1/tests/language/regress_12615_test.dart File tests/language/regress_12615_test.dart (right): https://codereview.chromium.org/22909032/diff/1/tests/language/regress_12615_test.dart#newcode3 tests/language/regress_12615_test.dart:3: // BSD-style license that can be found in ...
7 years, 4 months ago (2013-08-22 16:12:01 UTC) #2
Florian Schneider
Committed patchset #1 manually as r26585 (presubmit successful).
7 years, 4 months ago (2013-08-23 08:49:12 UTC) #3
Florian Schneider
7 years, 4 months ago (2013-08-23 08:49:33 UTC) #4
Message was sent while issue was closed.
https://codereview.chromium.org/22909032/diff/1/tests/language/regress_12615_...
File tests/language/regress_12615_test.dart (right):

https://codereview.chromium.org/22909032/diff/1/tests/language/regress_12615_...
tests/language/regress_12615_test.dart:3: // BSD-style license that can be found
in the LICENSE file.
On 2013/08/22 16:12:01, srdjan wrote:
> Please add comment what this test is testing. I assume it is not crashing as
the
> method name suggests.

Renaming it to test(). Not sure what to add as a comment: It tests that
try-catch works properly. - I don't want to elaborate over implementation
details here which can be found in the issue# and this CL.

Powered by Google App Engine
This is Rietveld 408576698