Issue 22904004: one space before opening brace in class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22904004: one space before opening brace in class (Closed)

Created:
7 years, 4 months ago by kevmoo-old

Modified:
7 years, 4 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

because Kasper cares R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=26286

Patch Set 2 : picky picky #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
M	pkg/unittest/lib/src/expect.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket_patch.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	sdk/lib/async/stream_impl.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tests/utils/recursive_import_test.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/src/native_DOMImplementation.dart	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM, but https://codereview.chromium.org/22904004/diff/1/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/22904004/diff/1/runtime/bin/socket_patch.dart#newcode5 runtime/bin/socket_patch.dart:5: patch class RawServerSocket { RawServerSocket { -> ...

7 years, 4 months ago (2013-08-16 05:35:20 UTC) #2

kevmoo-old

https://codereview.chromium.org/22904004/diff/1/runtime/bin/socket_patch.dart File runtime/bin/socket_patch.dart (right): https://codereview.chromium.org/22904004/diff/1/runtime/bin/socket_patch.dart#newcode5 runtime/bin/socket_patch.dart:5: patch class RawServerSocket { On 2013/08/16 05:35:20, kasperl wrote: ...

7 years, 4 months ago (2013-08-16 18:03:42 UTC) #3

kevmoo-old

7 years, 4 months ago (2013-08-16 18:04:53 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26286 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22904004: one space before opening brace in class (Closed)

Description

Patch Set 1 #

Patch Set 2 : picky picky #

Messages