Use predicates to check simple function types.

Use predicates to check simple function types.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26590

[karlklose, 2013-08-23 09:13:50]

LGTM.

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:605: bool isSimple() {
Could we move this check to a predicate in RuntimeTypes? The notion of
simplicity is part of the optimizations of our runtime type system and not of
the Dart language.

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2179: } else
if (!functionType.isSimple) {
Perhaps add a comment why these do not count as predicates and explain why they
are emitted.

https://codereview.chromium.org/22903036/diff/2001/tests/language/function_su...
File tests/language/function_subtype_simple1_test.dart (right):

https://codereview.chromium.org/22903036/diff/2001/tests/language/function_su...
tests/language/function_subtype_simple1_test.dart:323: /*Expect.isFalse(args0 is
Args0);
Uncomment.

[Johnni Winther, 2013-08-23 10:06:56]

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/dart_types.dart (right):

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/dart_types.dart:605: bool isSimple() {
On 2013/08/23 09:13:50, karlklose wrote:
> Could we move this check to a predicate in RuntimeTypes? The notion of
> simplicity is part of the optimizations of our runtime type system and not of
> the Dart language.

Done.

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
File sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart (right):

https://codereview.chromium.org/22903036/diff/2001/sdk/lib/_internal/compiler...
sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart:2179: } else
if (!functionType.isSimple) {
On 2013/08/23 09:13:50, karlklose wrote:
> Perhaps add a comment why these do not count as predicates and explain why
they
> are emitted.

Done.

https://codereview.chromium.org/22903036/diff/2001/tests/language/function_su...
File tests/language/function_subtype_simple1_test.dart (right):

https://codereview.chromium.org/22903036/diff/2001/tests/language/function_su...
tests/language/function_subtype_simple1_test.dart:323: /*Expect.isFalse(args0 is
Args0);
On 2013/08/23 09:13:50, karlklose wrote:
> Uncomment.

Removed.

[Johnni Winther, 2013-08-23 10:16:09]

Committed patchset #3 manually as r26590 (presubmit successful).