Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(261)

Issue 22897014: Fixes for Element API changes (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fixes for Element API changes The custom_element analyzer test started failing due to API changes on Element from the last roll. This should fix. TBR=jmesserly@google.com,sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=26382

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pkg/custom_element/lib/custom_element.dart View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
vsm
7 years, 4 months ago (2013-08-20 19:08:51 UTC) #1
vsm
Committed patchset #1 manually as r26382 (presubmit successful).
7 years, 4 months ago (2013-08-20 19:08:59 UTC) #2
Siggi Cherem (dart-lang)
lgtm
7 years, 4 months ago (2013-08-20 19:14:20 UTC) #3
Jennifer Messerly
I think we can delete this after Pete's custom elements change? And switch to extending ...
7 years, 4 months ago (2013-08-20 22:27:08 UTC) #4
Siggi Cherem (dart-lang)
On 2013/08/20 22:27:08, John Messerly wrote: > I think we can delete this after Pete's ...
7 years, 4 months ago (2013-08-20 22:37:20 UTC) #5
Jennifer Messerly
7 years, 4 months ago (2013-08-20 22:42:45 UTC) #6
Message was sent while issue was closed.
On 2013/08/20 22:37:20, Siggi Cherem (dart-lang) wrote:
> On 2013/08/20 22:27:08, John Messerly wrote:
> > I think we can delete this after Pete's custom elements change? And switch
to
> > extending the real HtmlElement
> 
> that would be really really cool. However, one thing to be careful here is how
> does this integrate with the old web_ui, will it continue to work OK?

hmmm, yeah, that's tricky :)

Can we just change the base class in web_ui?

    class WebComponent extends HtmlElement {
      ... compose children and stuff ...
    }

it's kinda funny because the xtag will be a real DOM node, just not one that is
attached to the document :). But it'll probably work.

Powered by Google App Engine
This is Rietveld 408576698