Issue 22896003: Only retain needed metadata constants.

Issue 22896003: Only retain needed metadata constants. (Closed)

Created:
7 years, 4 months ago by ahe

Modified:
7 years, 4 months ago

Reviewers:
karlklose, ngeoffray

CC:
reviews_dartlang.org, zarah, sra1

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Only retain needed metadata constants. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26056

Patch Set 2 : Fix copyAll bug #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -11 lines)			Patch
	M	dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	3 chunks	+70 lines, -10 lines	0 comments	Download
	M	dart/tests/compiler/dart2js/mirrors_used_test.dart	View		2 chunks	+33 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ngeoffray

LGTM! https://codereview.chromium.org/22896003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/22896003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1576 dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1576: copy(constant.keys); Why is that not copyAll? Maybe add ...

7 years, 4 months ago (2013-08-13 11:46:44 UTC) #2

ahe

Thank you, Nicolas! https://codereview.chromium.org/22896003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart File dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart (right): https://codereview.chromium.org/22896003/diff/1/dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart#newcode1576 dart/sdk/lib/_internal/compiler/implementation/js_backend/backend.dart:1576: copy(constant.keys); On 2013/08/13 11:46:44, ngeoffray wrote: ...

7 years, 4 months ago (2013-08-13 15:09:07 UTC) #3

ahe

7 years, 4 months ago (2013-08-13 15:30:22 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r26056 (presubmit successful).

Expand Messages | Collapse Messages