Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 22893043: Modify get_archive script to optionally download debug Dartium (Closed)

Created:
7 years, 4 months ago by vsm
Modified:
7 years, 4 months ago
Reviewers:
Emily Fortuna, Jacob
CC:
reviews_dartlang.org, Jennifer Messerly
Visibility:
Public.

Description

Modify get_archive script to optionally download debug Dartium It can be invoked as follows to easily get the latest debug build: > ./tools/get_archive.py -d dartium Removing old Dartium tree client/tests/dartium Copying gs://dartium-archive/dartium-lucid64-debug/dartium-lucid64-debug-26539.0.zip... Downloading: 756.45 MB/756.45 MB Successfully downloaded to client/tests/dartium R=jacobr@google.com Committed: https://code.google.com/p/dart/source/detail?r=26553

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address efortuna comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -23 lines) Patch
M tools/get_archive.py View 1 8 chunks +31 lines, -23 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vsm
7 years, 4 months ago (2013-08-22 20:27:45 UTC) #1
Jacob
LGTM!
7 years, 4 months ago (2013-08-22 20:30:25 UTC) #2
Emily Fortuna
looks good. one suggestion. https://chromiumcodereview.appspot.com/22893043/diff/1/tools/get_archive.py File tools/get_archive.py (right): https://chromiumcodereview.appspot.com/22893043/diff/1/tools/get_archive.py#newcode224 tools/get_archive.py:224: def GetFromGsutil(name, bot, directory, version_file, ...
7 years, 4 months ago (2013-08-22 20:34:00 UTC) #3
vsm
https://chromiumcodereview.appspot.com/22893043/diff/1/tools/get_archive.py File tools/get_archive.py (right): https://chromiumcodereview.appspot.com/22893043/diff/1/tools/get_archive.py#newcode224 tools/get_archive.py:224: def GetFromGsutil(name, bot, directory, version_file, latest_pattern, On 2013/08/22 20:34:01, ...
7 years, 4 months ago (2013-08-22 20:41:29 UTC) #4
vsm
7 years, 4 months ago (2013-08-22 20:41:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r26553 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698