Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 22893005: Fix some analyzer warnings in dart:io. (Closed)

Created:
7 years, 4 months ago by Bill Hesse
Modified:
7 years, 4 months ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix some analyzer warnings in dart:io. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=26051

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M sdk/lib/io/directory_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/io/file_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/io/http.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M sdk/lib/io/websocket_impl.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Bill Hesse
7 years, 4 months ago (2013-08-13 10:24:00 UTC) #1
Søren Gjesse
lgtm
7 years, 4 months ago (2013-08-13 13:21:51 UTC) #2
Bill Hesse
7 years, 4 months ago (2013-08-13 14:11:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26051 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698