Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 22892002: Fix issue 12369: compare kind of unary math instruction and not only the inputs to determine if at… (Closed)

Created:
7 years, 4 months ago by srdjan
Modified:
7 years, 4 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Fix issue 12369: compare kind of unary math instruction and not only the inputs to determine if attributes are equal. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=26014

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M runtime/vm/intermediate_language.h View 1 chunk +3 lines, -1 line 0 comments Download
M tests/language/math_vm_test.dart View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
srdjan
7 years, 4 months ago (2013-08-12 17:43:32 UTC) #1
regis
LGTM
7 years, 4 months ago (2013-08-12 17:48:21 UTC) #2
srdjan
7 years, 4 months ago (2013-08-12 17:54:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26014 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698