Issue 22891007: Remove flaky marker for csslib/test/declaration_test

Issue 22891007: Remove flaky marker for csslib/test/declaration_test (Closed)

Created:
7 years, 4 months ago by ricow1

Modified:
7 years, 4 months ago

Reviewers:
ahe, siva, kustermann

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Remove flaky marker for csslib/test/declaration_test This has been fixed in V8 and we rolled in a new version R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=26313

Patch Set 1 #

Patch Set 2 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -5 lines)			Patch
M	pkg/pkg.status	View	1	2 chunks	+1 line, -2 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	tests/lib/lib.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

ricow1

Committed patchset #2 manually as r26313 (presubmit successful).

7 years, 4 months ago (2013-08-19 13:23:08 UTC) #5

siva

7 years, 4 months ago (2013-08-19 20:48:20 UTC) #6

Message was sent while issue was closed.

Looks like this v8 roll fixed a bug in dart2js and a test
which was marked as failing is passing now:

FAILED: dart2js-d8 release_ia32 lib/typed_data/byte_data_test
Expected: ok fail 
Actual: pass
CommandOutput[dart2js]:
CommandOutput[d8]:

Command[dart2js]: out/ReleaseIA32/dart-sdk/bin/dart2js --allow-mock-compilation
--categories=all --minify --package-root=out/ReleaseIA32/packages/
/mnt/data/b/build/slave/dart2js-linux-release-minified-4-5/build/dart/tests/lib/typed_data/byte_data_test.dart
--out=/mnt/data/b/build/slave/dart2js-linux-release-minified-4-5/build/dart/out/ReleaseIA32/generated_tests/dart2js-d8-minified/tests_lib_typed_data_byte_data_test/out.js
Took 0:00:00.006000

Command[d8]:
/mnt/data/b/build/slave/dart2js-linux-release-minified-4-5/build/dart/third_party/d8/linux/d8
/mnt/data/b/build/slave/dart2js-linux-release-minified-4-5/build/dart/out/ReleaseIA32/generated_tests/dart2js-d8-minified/tests_lib_typed_data_byte_data_test/out.js
Took 0:00:00.035000

Short reproduction command (experimental):
    python tools/test.py -mrelease -t60 -rd8 --minified -cdart2js --use-sdk
lib/typed_data/byte_data_test

Expand Messages | Collapse Messages