Issue 22887014: Remove the certificate management methods from dart:io

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22887014: Remove the certificate management methods from dart:io (Closed)

Created:
7 years, 4 months ago by Søren Gjesse

Modified:
7 years, 4 months ago

Reviewers:
Mads Ager (google)

CC:
reviews_dartlang.org, vm-dev_dartlang.org, dgrove, Ivan Posva, Bill Hesse

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove the certificate management methods from dart:io Certificate management functions where added to dart:io in r25610 and r26002. However these functions where mutating the NSS database for the whole Dart process, and some functions where also persisting the changes to the database. This might cause issues when running multiple isolates as changes in one isolate will affect other isolates and could lead to unexpected results. These functions are removed from dart:io for now. BUG=http://dartbug.com/8227 TBR=ager@google.com Committed: https://code.google.com/p/dart/source/detail?r=26194

Patch Set 1 #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+77 lines, -812 lines)			Patch
M	runtime/bin/io_natives.cc	View	1 chunk	+1 line, -6 lines	0 comments	Download
M	runtime/bin/net/nss.gyp	View	4 chunks	+0 lines, -16 lines	0 comments	Download
M	runtime/bin/secure_socket.h	View	3 chunks	+3 lines, -6 lines	0 comments	Download
M	runtime/bin/secure_socket.cc	View	13 chunks	+69 lines, -342 lines	0 comments	Download
M	runtime/bin/secure_socket_patch.dart	View	1 chunk	+2 lines, -21 lines	0 comments	Download
M	sdk/lib/_internal/lib/io_patch.dart	View	1 chunk	+1 line, -25 lines	0 comments	Download
M	sdk/lib/io/secure_socket.dart	View	2 chunks	+2 lines, -113 lines	0 comments	Download
D	tests/standalone/io/certificate_test.dart	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	tests/standalone/io/certificate_test_client.dart	View	1 chunk	+0 lines, -65 lines	0 comments	Download
D	tests/standalone/io/certificate_test_client_database.dart	View	1 chunk	+0 lines, -42 lines	0 comments	Download
D	tests/standalone/io/delete_a_directory_later.dart	View	1 chunk	+0 lines, -12 lines	0 comments	Download
D	tests/standalone/io/pkcert/localhost.p12	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
D	tests/standalone/io/pkcert/myauthority.pem	View	1 chunk	+0 lines, -11 lines	0 comments	Download
D	tests/standalone/io/user_certificate_test.dart	View	1 chunk	+0 lines, -116 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

Committed patchset #1 manually as r26194 (presubmit successful).

7 years, 4 months ago (2013-08-15 14:56:09 UTC) #2

Message was sent while issue was closed.

Rubberstamp LGTM

Expand Messages | Collapse Messages