Issue 228863003: Warn when serving an asset from "asset".

Issue 228863003: Warn when serving an asset from "asset". (Closed)

Created:
6 years, 8 months ago by Bob Nystrom

Modified:
6 years, 8 months ago

Reviewers:
nweiz

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Warn when serving an asset from "asset". BUG=https://code.google.com/p/dart/issues/detail?id=18085 RELNOTE=Warn if pub serve serves an asset from the deprecated "asset" directory. R=nweiz@google.com Committed: https://code.google.com/p/dart/source/detail?r=34939

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix typo. #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -0 lines)			Patch
	M	sdk/lib/_internal/pub/lib/src/barback/barback_server.dart	View		1 chunk	+19 lines, -0 lines	0 comments	Download
	A	sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart	View	1	1 chunk	+56 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

nweiz

lgtm https://codereview.chromium.org/228863003/diff/1/sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart File sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart (right): https://codereview.chromium.org/228863003/diff/1/sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart#newcode33 sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart:33: integration("warns if an asset from a dependencie's 'asset' ...

6 years, 8 months ago (2014-04-09 20:29:04 UTC) #2

Bob Nystrom

Committed patchset #2 manually as r34939 (presubmit successful).

6 years, 8 months ago (2014-04-10 19:18:47 UTC) #3

Bob Nystrom

6 years, 8 months ago (2014-04-15 00:46:06 UTC) #4

Message was sent while issue was closed.

Forgot to send this out.

https://codereview.chromium.org/228863003/diff/1/sdk/lib/_internal/pub/test/s...
File sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart
(right):

https://codereview.chromium.org/228863003/diff/1/sdk/lib/_internal/pub/test/s...
sdk/lib/_internal/pub/test/serve/warns_on_serve_from_asset_test.dart:33:
integration("warns if an asset from a dependencie's 'asset' directory is "
On 2014/04/09 20:29:04, nweiz wrote:
> "dependencie's" -> "dependency's"

Done.

Expand Messages | Collapse Messages