Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 22883008: starting to work on unit test config interface (Closed)

Created:
7 years, 4 months ago by kevmoo-old
Modified:
7 years, 4 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

starting to work on unit test config interface R=gram@google.com Committed: https://code.google.com/p/dart/source/detail?r=26215

Patch Set 1 #

Patch Set 2 : first pass #

Patch Set 3 : nits #

Patch Set 4 : more cleanup #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -303 lines) Patch
M pkg/scheduled_test/test/metatest.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/html_config.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/html_enhanced_config.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/interactive_html_config.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/lib/src/config.dart View 1 1 chunk +0 lines, -243 lines 2 comments Download
A pkg/unittest/lib/src/configuration.dart View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A + pkg/unittest/lib/src/simple_configuration.dart View 1 2 3 10 chunks +12 lines, -39 lines 0 comments Download
M pkg/unittest/lib/unittest.dart View 1 2 3 2 chunks +14 lines, -12 lines 0 comments Download
M pkg/unittest/lib/vm_config.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M pkg/unittest/test/unittest_test_utils.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M utils/testrunner/standard_test_runner.dart View 1 2 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo-old
Configuration introduces a lot of members that aren't used by the core test system but ...
7 years, 4 months ago (2013-08-15 17:55:39 UTC) #1
gram
lgtm, but I think you should add a todo to check whether each of the ...
7 years, 4 months ago (2013-08-15 20:38:00 UTC) #2
kevmoo-old
I'll open a bug (CC you and me) to look into the subclasses https://codereview.chromium.org/22883008/diff/9001/pkg/unittest/lib/src/config.dart File ...
7 years, 4 months ago (2013-08-15 20:46:16 UTC) #3
kevmoo-old
7 years, 4 months ago (2013-08-15 20:48:41 UTC) #4
Message was sent while issue was closed.
Committed patchset #4 manually as r26215 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698