Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 22881003: Implement visitCascade/visitCascadeReceiver in inferrer_visitor.dart (Closed)

Created:
7 years, 4 months ago by kustermann
Modified:
7 years, 4 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement visitCascade/visitCascadeReceiver in inferrer_visitor.dart R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26115

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -6 lines) Patch
M sdk/lib/_internal/compiler/implementation/types/inferrer_visitor.dart View 2 chunks +8 lines, -6 lines 0 comments Download
M tests/compiler/dart2js/simple_inferrer_test.dart View 1 3 chunks +22 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
7 years, 4 months ago (2013-08-13 15:06:54 UTC) #1
ngeoffray
LGTM, please also add a test in tests/compiler/dart2js/simple_inferrer_test.dart.
7 years, 4 months ago (2013-08-13 16:40:15 UTC) #2
kustermann
7 years, 4 months ago (2013-08-14 12:42:31 UTC) #3
ngeoffray
LGTM! Thanks for the test.
7 years, 4 months ago (2013-08-14 12:43:47 UTC) #4
kustermann
7 years, 4 months ago (2013-08-14 12:45:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r26115 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698