Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 22877044: add library descriptions for sequence_zip and the libraries it exports (Closed)

Created:
7 years, 3 months ago by Kathy Walrath
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

add library descriptions for sequence_zip and the libraries it exports R=lrn@google.com Committed: https://code.google.com/p/dart/source/detail?r=26691

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M pkg/sequence_zip/lib/iterable_zip.dart View 1 chunk +6 lines, -0 lines 2 comments Download
M pkg/sequence_zip/lib/sequence_zip.dart View 1 chunk +9 lines, -0 lines 0 comments Download
M pkg/sequence_zip/lib/stream_zip.dart View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
lgtm https://codereview.chromium.org/22877044/diff/1/pkg/sequence_zip/lib/iterable_zip.dart File pkg/sequence_zip/lib/iterable_zip.dart (right): https://codereview.chromium.org/22877044/diff/1/pkg/sequence_zip/lib/iterable_zip.dart#newcode9 pkg/sequence_zip/lib/iterable_zip.dart:9: * [sequence_zip](#sequence_zip) library. Will the fragment-link work in ...
7 years, 3 months ago (2013-08-26 13:57:29 UTC) #1
Kathy Walrath
https://codereview.chromium.org/22877044/diff/1/pkg/sequence_zip/lib/iterable_zip.dart File pkg/sequence_zip/lib/iterable_zip.dart (right): https://codereview.chromium.org/22877044/diff/1/pkg/sequence_zip/lib/iterable_zip.dart#newcode9 pkg/sequence_zip/lib/iterable_zip.dart:9: * [sequence_zip](#sequence_zip) library. On 2013/08/26 13:57:30, Lasse Reichstein Nielsen ...
7 years, 3 months ago (2013-08-26 14:15:58 UTC) #2
Kathy Walrath
On 2013/08/26 14:15:58, Kathy Walrath wrote: > https://codereview.chromium.org/22877044/diff/1/pkg/sequence_zip/lib/iterable_zip.dart > File pkg/sequence_zip/lib/iterable_zip.dart (right): > > https://codereview.chromium.org/22877044/diff/1/pkg/sequence_zip/lib/iterable_zip.dart#newcode9 ...
7 years, 3 months ago (2013-08-27 07:51:56 UTC) #3
Kathy Walrath
7 years, 3 months ago (2013-08-27 08:00:19 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26691 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698