Issue 22877005: Workaround for bug 11834 with Chrome XHR

Issue 22877005: Workaround for bug 11834 with Chrome XHR (Closed)

Created:
7 years, 4 months ago by Alan Knight

Modified:
7 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Workaround for bug 11834 with Chrome XHR R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26028

Patch Set 2 : Added issue number #

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -4 lines)			Patch
	M	pkg/intl/lib/src/http_request_data_reader.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
	M	pkg/pkg.status	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm with one change, please https://codereview.chromium.org/22877005/diff/1/pkg/intl/lib/src/http_request_data_reader.dart File pkg/intl/lib/src/http_request_data_reader.dart (right): https://codereview.chromium.org/22877005/diff/1/pkg/intl/lib/src/http_request_data_reader.dart#newcode23 pkg/intl/lib/src/http_request_data_reader.dart:23: // TODO(alanknight): Remove this ...

7 years, 4 months ago (2013-08-12 20:11:52 UTC) #2

Alan Knight

https://codereview.chromium.org/22877005/diff/1/pkg/intl/lib/src/http_request_data_reader.dart File pkg/intl/lib/src/http_request_data_reader.dart (right): https://codereview.chromium.org/22877005/diff/1/pkg/intl/lib/src/http_request_data_reader.dart#newcode23 pkg/intl/lib/src/http_request_data_reader.dart:23: // TODO(alanknight): Remove this once it's not necessary for ...

7 years, 4 months ago (2013-08-12 20:31:51 UTC) #3

Alan Knight

7 years, 4 months ago (2013-08-12 20:33:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r26028 (presubmit successful).

Expand Messages | Collapse Messages