Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 22876025: The peer pointer was not being setup at all, fixed that and added a test case (Closed)

Created:
7 years, 4 months ago by siva
Modified:
7 years, 4 months ago
Reviewers:
Ivan Posva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

The peer pointer was not being setup at all, fixed that and added a test case for it. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=26561

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M runtime/vm/dart_api_impl_test.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
siva
7 years, 4 months ago (2013-08-22 21:52:11 UTC) #1
Ivan Posva
LGTM -ip
7 years, 4 months ago (2013-08-22 22:03:36 UTC) #2
siva
7 years, 4 months ago (2013-08-22 22:05:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r26561 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698