Add ASCII encoding to lib/convert.

Add ASCII encoding to lib/convert.

Reuses part of LATIN1 encoding.

R=floitsch@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26518

[floitsch, 2013-08-22 12:34:31]

LGTM.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart
File sdk/lib/convert/ascii.dart (right):

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:10: * This instance provides a convenient access to
the most common ISO Latin 1
not ISO Latin 1.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:15: *     var encoded = LATIN1.encode("This is
ASCII!");
ASCII

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:16: *     var decoded = LATIN1.decode([0x62, 0x6c,
0x61, 0x61, 0x62, 0x61, 0x65,
maybe still pick a better ASCII example.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:24: * A [AsciiCodec] encodes strings to ASCII bytes
An

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:35: * Calls to the [decode] method can override this
default.
It is not clear that you are talking about the "allowInvalid" default (and not
the replacement character default).

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:67: // Superclass for [AsciiEncoder] and
[Latin1nocoder].
Latin1Encoder

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:106: * This class converts strings of only ISO
Latin-1 characters to bytes.
Ascii

https://codereview.chromium.org/22875034/diff/1/tests/lib/convert/ascii_test....
File tests/lib/convert/ascii_test.dart (right):

https://codereview.chromium.org/22875034/diff/1/tests/lib/convert/ascii_test....
tests/lib/convert/ascii_test.dart:9: "pure ascii",
add test with \x00.

https://codereview.chromium.org/22875034/diff/1/tests/lib/convert/ascii_test....
tests/lib/convert/ascii_test.dart:17: "Edge case Latin-1 \u{ff}",
Ascii.

[Lasse Reichstein Nielsen, 2013-08-22 13:04:56]

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart
File sdk/lib/convert/ascii.dart (right):

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:10: * This instance provides a convenient access to
the most common ISO Latin 1
On 2013/08/22 12:34:31, floitsch wrote:
> not ISO Latin 1.

Done.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:15: *     var encoded = LATIN1.encode("This is
ASCII!");
On 2013/08/22 12:34:31, floitsch wrote:
> ASCII

Done.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:16: *     var decoded = LATIN1.decode([0x62, 0x6c,
0x61, 0x61, 0x62, 0x61, 0x65,
Pfft!
Done.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:24: * A [AsciiCodec] encodes strings to ASCII bytes
On 2013/08/22 12:34:31, floitsch wrote:
> An

Done.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:35: * Calls to the [decode] method can override this
default.
On 2013/08/22 12:34:31, floitsch wrote:
> It is not clear that you are talking about the "allowInvalid" default (and not
> the replacement character default).

Done.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:67: // Superclass for [AsciiEncoder] and
[Latin1nocoder].
On 2013/08/22 12:34:31, floitsch wrote:
> Latin1Encoder

Done.

https://codereview.chromium.org/22875034/diff/1/sdk/lib/convert/ascii.dart#ne...
sdk/lib/convert/ascii.dart:106: * This class converts strings of only ISO
Latin-1 characters to bytes.
On 2013/08/22 12:34:31, floitsch wrote:
> Ascii

Done.

https://codereview.chromium.org/22875034/diff/1/tests/lib/convert/ascii_test....
File tests/lib/convert/ascii_test.dart (right):

https://codereview.chromium.org/22875034/diff/1/tests/lib/convert/ascii_test....
tests/lib/convert/ascii_test.dart:9: "pure ascii",
On 2013/08/22 12:34:31, floitsch wrote:
> add test with \x00.

Done.

https://codereview.chromium.org/22875034/diff/1/tests/lib/convert/ascii_test....
tests/lib/convert/ascii_test.dart:17: "Edge case Latin-1 \u{ff}",
Actually, this is a Latin-1 edge cases in an ASCII test.
Reworded.

[Lasse Reichstein Nielsen, 2013-08-22 13:05:41]

Committed patchset #2 manually as r26518 (presubmit successful).