Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 22871017: Add one-line description to dart:isolate, plus a start at doc comment cleanup. (Closed)

Created:
7 years, 4 months ago by Kathy Walrath
Modified:
7 years, 4 months ago
Reviewers:
sethladd
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add one-line description to dart:isolate, plus a start at doc comment cleanup. R=sethladd@google.com Committed: https://code.google.com/p/dart/source/detail?r=26498

Patch Set 1 #

Total comments: 4

Patch Set 2 : another crack at it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -33 lines) Patch
M sdk/lib/isolate/isolate.dart View 1 3 chunks +37 lines, -15 lines 0 comments Download
M sdk/lib/isolate/isolate_stream.dart View 7 chunks +24 lines, -18 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Kathy Walrath
Please take a look, Seth. I've confirmed that this generates reasonable doc in the new ...
7 years, 4 months ago (2013-08-21 13:15:05 UTC) #1
sethladd
https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart#newcode7 sdk/lib/isolate/isolate.dart:7: * threads of execution that communicate via messages. threads ...
7 years, 4 months ago (2013-08-21 17:23:17 UTC) #2
Kathy Walrath
https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart#newcode7 sdk/lib/isolate/isolate.dart:7: * threads of execution that communicate via messages. On ...
7 years, 4 months ago (2013-08-21 17:44:24 UTC) #3
sethladd
lgtm https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart#newcode7 sdk/lib/isolate/isolate.dart:7: * threads of execution that communicate via messages. ...
7 years, 4 months ago (2013-08-21 19:16:42 UTC) #4
sethladd
oops, didn't mean lgtm
7 years, 4 months ago (2013-08-21 19:17:02 UTC) #5
Kathy Walrath
https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart File sdk/lib/isolate/isolate.dart (right): https://chromiumcodereview.appspot.com/22871017/diff/1/sdk/lib/isolate/isolate.dart#newcode7 sdk/lib/isolate/isolate.dart:7: * threads of execution that communicate via messages. On ...
7 years, 4 months ago (2013-08-21 21:23:10 UTC) #6
sethladd
I'm just worried that thread and worker (in the HTML5 world) are overloaded and come ...
7 years, 4 months ago (2013-08-21 22:01:39 UTC) #7
Kathy Walrath
How about this? I know worker and thread are overloaded, but I think people will ...
7 years, 4 months ago (2013-08-21 23:06:05 UTC) #8
Kathy Walrath
7 years, 4 months ago (2013-08-22 00:38:44 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 manually as r26498 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698