Compensate for the lack of code motion in licm.

Compensate for the lack of code motion in licm.

R=karlklose@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26265

[karlklose, 2013-08-15 12:58:02]

lgtm

https://codereview.chromium.org/22871008/diff/5002/tests/compiler/dart2js/lic...
File tests/compiler/dart2js/licm_test.dart (right):

https://codereview.chromium.org/22871008/diff/5002/tests/compiler/dart2js/lic...
tests/compiler/dart2js/licm_test.dart:29: int checkIndex = generated.indexOf('if
(count == null)');
Consider testing this with a regular expression like:
 'if (count == null).+while(true)'
.

[ngeoffray, 2013-08-15 13:55:29]

Thanks Karl, PTAL, I also needed to check that the loop was always taken.

https://codereview.chromium.org/22871008/diff/5002/tests/compiler/dart2js/lic...
File tests/compiler/dart2js/licm_test.dart (right):

https://codereview.chromium.org/22871008/diff/5002/tests/compiler/dart2js/lic...
tests/compiler/dart2js/licm_test.dart:29: int checkIndex = generated.indexOf('if
(count == null)');
On 2013/08/15 12:58:02, karlklose wrote:
> Consider testing this with a regular expression like:
>  'if (count == null).+while(true)'
> .

Done.

[karlklose, 2013-08-16 10:46:07]

On 2013/08/15 13:55:29, ngeoffray wrote:
> Thanks Karl, PTAL, I also needed to check that the loop was always taken.
> 
>
https://codereview.chromium.org/22871008/diff/5002/tests/compiler/dart2js/lic...
> File tests/compiler/dart2js/licm_test.dart (right):
> 
>
https://codereview.chromium.org/22871008/diff/5002/tests/compiler/dart2js/lic...
> tests/compiler/dart2js/licm_test.dart:29: int checkIndex =
generated.indexOf('if
> (count == null)');
> On 2013/08/15 12:58:02, karlklose wrote:
> > Consider testing this with a regular expression like:
> >  'if (count == null).+while(true)'
> > .
> 
> Done.

SLGTM.

[ngeoffray, 2013-08-16 10:48:10]

Committed patchset #2 manually as r26265 (presubmit successful).