Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 22866025: Always generate full unoptimized code for intrinsified methods. (Closed)

Created:
7 years, 3 months ago by Florian Schneider
Modified:
7 years, 3 months ago
Reviewers:
srdjan
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Always generate full unoptimized code for intrinsified methods. Until now, we skipped regular code generation for some intrinsics because the body was unreachable (no slow case). With inlining and optimizing those methods, we may need the unoptimized code for deoptimization support. Instead of deciding case-by-case which of these methods may potentially deoptimize, we always generate the full unoptimized code now, together with the corresponding deoptimization info. R=srdjan@google.com Committed: https://code.google.com/p/dart/source/detail?r=26703

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -558 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/flow_graph_compiler.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_ia32.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_mips.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M runtime/vm/flow_graph_compiler_x64.cc View 1 chunk +2 lines, -9 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 43 chunks +76 lines, -127 lines 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 51 chunks +77 lines, -127 lines 0 comments Download
M runtime/vm/intrinsifier_mips.cc View 46 chunks +76 lines, -127 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 49 chunks +77 lines, -131 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Florian Schneider
7 years, 3 months ago (2013-08-26 12:36:42 UTC) #1
srdjan
lgtm
7 years, 3 months ago (2013-08-26 16:03:54 UTC) #2
Florian Schneider
7 years, 3 months ago (2013-08-27 11:14:15 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r26703 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698