Add a parseDartString method to pkg/analyzer.

Add a parseDartString method to pkg/analyzer.

R=brianwilkerson@google.com, scheglov@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26673

[scheglov, 2013-08-22 23:23:41]

LGTM, but I've like Brian to take a look too.

[Brian Wilkerson, 2013-08-23 14:19:29]

LGTM

https://codereview.chromium.org/22865035/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/analyzer.dart (right):

https://codereview.chromium.org/22865035/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/analyzer.dart:54: CompilationUnit
parseDartString(String contents, {String name}) {
It might be better to name this something like parseCompilationUnit so that we
can later add methods like parseStatement and parseExpression.

https://codereview.chromium.org/22865035/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/analyzer.dart:55: var source = name == null ? null
: new StringSource(contents, name);
It would be good to have some tests for this. In particular, it would be good to
know whether it's really OK to pass in a null source when there are errors being
generated. It might be better to give 'name' a default value of something like
"--unnamed--".

[nweiz, 2013-08-26 17:03:39]

https://codereview.chromium.org/22865035/diff/1/pkg/analyzer_experimental/lib...
File pkg/analyzer_experimental/lib/analyzer.dart (right):

https://codereview.chromium.org/22865035/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/analyzer.dart:54: CompilationUnit
parseDartString(String contents, {String name}) {
On 2013/08/23 14:19:29, Brian Wilkerson wrote:
> It might be better to name this something like parseCompilationUnit so that we
> can later add methods like parseStatement and parseExpression.

Done.

https://codereview.chromium.org/22865035/diff/1/pkg/analyzer_experimental/lib...
pkg/analyzer_experimental/lib/analyzer.dart:55: var source = name == null ? null
: new StringSource(contents, name);
On 2013/08/23 14:19:29, Brian Wilkerson wrote:
> It would be good to have some tests for this. In particular, it would be good
to
> know whether it's really OK to pass in a null source when there are errors
being
> generated. It might be better to give 'name' a default value of something like
> "--unnamed--".

The error message does default to "<unknown source>" if the source is null, but
AnalyzerError is unable to format the exception properly. I've changed it to
create a StringSource with name "<unknown source>".

I've also added a few tests.

[Brian Wilkerson, 2013-08-26 17:11:16]

LGTM

[nweiz, 2013-08-26 22:06:58]

Committed patchset #2 manually as r26673 (presubmit successful).

[tatumizer, 2013-08-26 23:57:53]

Can you make parseDartString and parseJsonString a part of standard library?
(Also, the reverse operations). There was an "issue" about it, but apparently
there was no appropriate place found for these functions. Maybe make them part
of "convert" lib?