Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Issue 22865010: Fix status file to account for dart2dart minified mode failure (Closed)

Created:
7 years, 4 months ago by siva
Modified:
7 years, 4 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix status file to account for dart2dart minified mode failure (error_stack_trace1_test.dart depends on method names) R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26082

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M tests/corelib/corelib.status View 1 chunk +3 lines, -0 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
siva
7 years, 4 months ago (2013-08-13 20:04:04 UTC) #1
ahe
LGTM! https://codereview.chromium.org/22865010/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/22865010/diff/1/tests/corelib/corelib.status#newcode96 tests/corelib/corelib.status:96: error_stack_trace1_test: Fail, OK # Fails in minified mode, ...
7 years, 4 months ago (2013-08-13 20:08:38 UTC) #2
siva
Thanks. https://codereview.chromium.org/22865010/diff/1/tests/corelib/corelib.status File tests/corelib/corelib.status (right): https://codereview.chromium.org/22865010/diff/1/tests/corelib/corelib.status#newcode96 tests/corelib/corelib.status:96: error_stack_trace1_test: Fail, OK # Fails in minified mode, ...
7 years, 4 months ago (2013-08-13 20:11:56 UTC) #3
siva
7 years, 4 months ago (2013-08-13 20:21:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r26082 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698