Issue 228643005: Add to co19 status files after co19 roll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228643005: Add to co19 status files after co19 roll. (Closed)

Created:
6 years, 8 months ago by Bill Hesse

Modified:
6 years, 8 months ago

Reviewers:
kustermann

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add to co19 status files after co19 roll. BUG= R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=34830

Patch Set 1 #

Total comments: 2

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	tests/co19/co19-analyzer.status	View		1 chunk	+1 line, -0 lines	2 comments	Download
	M	tests/co19/co19-co19.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kustermann

lgtm https://codereview.chromium.org/228643005/diff/1/tests/co19/co19-analyzer.status File tests/co19/co19-analyzer.status (right): https://codereview.chromium.org/228643005/diff/1/tests/co19/co19-analyzer.status#newcode134 tests/co19/co19-analyzer.status:134: #co19 issue 677 Is this block comment outdated.

6 years, 8 months ago (2014-04-08 15:40:03 UTC) #2

Bill Hesse

Committed patchset #1 manually as r34830 (presubmit successful).

6 years, 8 months ago (2014-04-08 15:42:48 UTC) #3

Bill Hesse

6 years, 8 months ago (2014-04-08 22:42:10 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/228643005/diff/1/tests/co19/co19-analyzer.status
File tests/co19/co19-analyzer.status (right):

https://codereview.chromium.org/228643005/diff/1/tests/co19/co19-analyzer.sta...
tests/co19/co19-analyzer.status:134: #co19 issue 677
On 2014/04/08 15:40:04, kustermann wrote:
> Is this block comment outdated.

Sure.

Expand Messages | Collapse Messages