nits from cr 22070003

nits from cr 22070003

R=lrn@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26076

[kevmoo-old, 2013-08-12 15:48:09]

Nits from 22070003

[Lasse Reichstein Nielsen, 2013-08-13 09:05:55]

lgtm

https://codereview.chromium.org/22860004/diff/1/sdk/lib/convert/line_splitter...
File sdk/lib/convert/line_splitter.dart (right):

https://codereview.chromium.org/22860004/diff/1/sdk/lib/convert/line_splitter...
sdk/lib/convert/line_splitter.dart:56: void adder(String val)) {
Indent to align with "String chunk".

https://codereview.chromium.org/22860004/diff/1/tests/lib/convert/line_splitt...
File tests/lib/convert/line_splitter_test.dart (right):

https://codereview.chromium.org/22860004/diff/1/tests/lib/convert/line_splitt...
tests/lib/convert/line_splitter_test.dart:125: Expect.equals(lines.removeAt(0),
line);
Tricky. I don't like modifying my expectations. If it goes wrong, it's harder to
debug.

How about: 
  
  int index = 0;
  stream.listen((line) {
    Expect.equals(lines[index++], line);
  });

Perhaps even rename "lines" to "expectedLines".

https://codereview.chromium.org/22860004/diff/1/tests/lib/convert/line_splitt...
tests/lib/convert/line_splitter_test.dart:135: Expect.isTrue(lines.isEmpty,
'should be done here...');
Expect.equals(expectedLines.length, index, "Should be done ...");

[Søren Gjesse, 2013-08-13 13:06:10]

lgtm

[kevmoo-old, 2013-08-13 18:47:16]

https://codereview.chromium.org/22860004/diff/1/sdk/lib/convert/line_splitter...
File sdk/lib/convert/line_splitter.dart (right):

https://codereview.chromium.org/22860004/diff/1/sdk/lib/convert/line_splitter...
sdk/lib/convert/line_splitter.dart:56: void adder(String val)) {
On 2013/08/13 09:05:55, Lasse Reichstein Nielsen wrote:
> Indent to align with "String chunk".

Done.

https://codereview.chromium.org/22860004/diff/1/tests/lib/convert/line_splitt...
File tests/lib/convert/line_splitter_test.dart (right):

https://codereview.chromium.org/22860004/diff/1/tests/lib/convert/line_splitt...
tests/lib/convert/line_splitter_test.dart:125: Expect.equals(lines.removeAt(0),
line);
On 2013/08/13 09:05:55, Lasse Reichstein Nielsen wrote:
> Tricky. I don't like modifying my expectations. If it goes wrong, it's harder
to
> debug.
> 
> How about: 
>   
>   int index = 0;
>   stream.listen((line) {
>     Expect.equals(lines[index++], line);
>   });
> 
> Perhaps even rename "lines" to "expectedLines".

Done.

https://codereview.chromium.org/22860004/diff/1/tests/lib/convert/line_splitt...
tests/lib/convert/line_splitter_test.dart:135: Expect.isTrue(lines.isEmpty,
'should be done here...');
On 2013/08/13 09:05:55, Lasse Reichstein Nielsen wrote:
> Expect.equals(expectedLines.length, index, "Should be done ...");

Done.

[kevmoo-old, 2013-08-13 18:53:46]

Committed patchset #3 manually as r26076 (presubmit successful).