Issue 22859038: Use new Dart API functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22859038: Use new Dart API functions (Closed)

Created:
7 years, 4 months ago by siva

Modified:
7 years, 4 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Use new Dart API functions Dart_GetNativeIntegerArgument Dart_GetNativeBooleanArgument Dart_GetNativeDoubleArgument R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=26500

Patch Set 3 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	tools/dom/scripts/systemnative.py	View	1 2	1 chunk	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/22859038/diff/3001/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/22859038/diff/3001/tools/dom/scripts/systemnative.py#newcode984 tools/dom/scripts/systemnative.py:984: else: Perhaps assert ...native_type() == 'int' here?

7 years, 4 months ago (2013-08-21 22:27:57 UTC) #2

siva

https://codereview.chromium.org/22859038/diff/3001/tools/dom/scripts/systemnative.py File tools/dom/scripts/systemnative.py (right): https://codereview.chromium.org/22859038/diff/3001/tools/dom/scripts/systemnative.py#newcode984 tools/dom/scripts/systemnative.py:984: else: On 2013/08/21 22:27:58, vsm wrote: > Perhaps assert ...

7 years, 4 months ago (2013-08-22 00:46:47 UTC) #3

siva

7 years, 4 months ago (2013-08-22 01:16:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r26500 (presubmit successful).

Expand Messages | Collapse Messages

Issue 22859038: Use new Dart API functions (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages