Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(718)

Issue 22859004: Improve type literals in minified mode. (Closed)

Created:
7 years, 4 months ago by ahe
Modified:
7 years, 4 months ago
Reviewers:
karlklose, ngeoffray
CC:
reviews_dartlang.org, Johnni Winther
Visibility:
Public.

Description

Improve type literals in minified mode. R=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26187

Patch Set 1 #

Patch Set 2 : Merged with bleeding_edge #

Patch Set 3 : Added a test, and changed how names are unmangled. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M dart/sdk/lib/_internal/lib/js_helper.dart View 1 2 1 chunk +4 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/lib/js_mirrors.dart View 1 2 chunks +2 lines, -1 line 0 comments Download
M dart/sdk/lib/_internal/lib/js_names.dart View 1 2 4 chunks +20 lines, -2 lines 0 comments Download
M dart/sdk/lib/_internal/lib/js_rti.dart View 1 2 3 chunks +12 lines, -3 lines 0 comments Download
A + dart/tests/lib/mirrors/unmangled_type_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
ahe
This makes type literals work better in minified code.
7 years, 4 months ago (2013-08-13 21:42:30 UTC) #1
ngeoffray
LGTM
7 years, 4 months ago (2013-08-14 08:00:14 UTC) #2
ahe
PTAL
7 years, 4 months ago (2013-08-14 18:02:58 UTC) #3
ngeoffray
Still LGTM
7 years, 4 months ago (2013-08-15 06:54:01 UTC) #4
ahe
7 years, 4 months ago (2013-08-15 11:32:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as r26187 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698