Upgrade to use stable `package:googleapis/v1.dart` of datastore

Upgrade to use stable `package:googleapis/v1.dart` of datastore


BUG=https://github.com/dart-lang/gcloud/issues/41
R=sgjesse@google.com, whesse@google.com

Committed: https://github.com/dart-lang/gcloud/commit/8480c62531fb85389b44aa0364622cf357f29118

[kustermann, 2016-08-26 16:14:35]

Patchset #2 (id:20001) has been deleted

[kustermann, 2016-08-26 16:52:50]

Patchset #3 (id:60001) has been deleted

[kustermann, 2016-08-26 16:52:54]

Patchset #2 (id:40001) has been deleted

[kustermann, 2016-08-26 16:56:50]

kustermann@google.com changed reviewers:
+ whesse@google.com

[kustermann, 2016-08-26 16:57:09]

Description was changed from

==========
Upgrade to use stable `package:googleapis/v1.dart` of datastore
==========

to

==========
Upgrade to use stable `package:googleapis/v1.dart` of datastore


BUG=https://github.com/dart-lang/gcloud/issues/41
==========

[Bill Hesse, 2016-08-26 17:55:18]

lgtm

[kustermann, 2016-08-29 09:21:22]

kustermann@google.com changed reviewers:
+ sgjesse@google.com

[kustermann, 2016-08-29 09:21:22]

@Soeren: You don't have to take a look, but feedback would be welcome.

[Søren Gjesse, 2016-08-29 10:29:09]

LGTM, thanks for fixing this!

https://codereview.chromium.org/2285803002/diff/100001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2285803002/diff/100001/CHANGELOG.md#newcode1
CHANGELOG.md:1: ## 0.2.1
Maybe bump this to 0.3.0? I know that the rules for 0.x.y are different. However
you could argue that the removal of the s~ prefix makes this a breaking change -
or is the s~ prefix still supported?

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
File lib/src/datastore_impl.dart (right):

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
lib/src/datastore_impl.dart:105: ..nullValue = "NULL_VALUE";
How does this nullValue thing work? Is this required to have the value
"NULL_VALUE", or will any (non null?) value for nullValue indicate "null"?

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
lib/src/datastore_impl.dart:144: static _convertApi2DatastoreProperty(api.Value
value) {
Add explicit dynamic here?

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
lib/src/datastore_impl.dart:162: else if (value.entityValue != null)
Why is value.nullValue not handled here?

[kevmoo, 2016-08-29 15:59:24]

kevmoo@google.com changed reviewers:
+ kevmoo@google.com

[kevmoo, 2016-08-29 15:59:25]

DBC

https://codereview.chromium.org/2285803002/diff/100001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2285803002/diff/100001/pubspec.yaml#newcode14
pubspec.yaml:14: http_parser: '>=2.0.0 <3.0.0'
While you're at it: upgrade this to <4.0.0

[kustermann, 2016-08-29 16:24:04]

https://codereview.chromium.org/2285803002/diff/100001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2285803002/diff/100001/CHANGELOG.md#newcode1
CHANGELOG.md:1: ## 0.2.1
On 2016/08/29 10:29:09, Søren Gjesse wrote:
> Maybe bump this to 0.3.0? I know that the rules for 0.x.y are different.
However
> you could argue that the removal of the s~ prefix makes this a breaking change
-
> or is the s~ prefix still supported?

Done.

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
File lib/src/datastore_impl.dart (right):

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
lib/src/datastore_impl.dart:105: ..nullValue = "NULL_VALUE";
On 2016/08/29 10:29:09, Søren Gjesse wrote:
> How does this nullValue thing work? Is this required to have the value
> "NULL_VALUE", or will any (non null?) value for nullValue indicate "null"?

It is an enum and the enum values are ["NULL_VALUE"].

The funny thing is: If I send just 'new api.Value()' (which translates to "{}")
I get an error saying the property doesn't contain a value.

But when I receive data, I never get '{ nullValue: "NULL_VALUE" }, I just get
"{}"

:-/

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
lib/src/datastore_impl.dart:144: static _convertApi2DatastoreProperty(api.Value
value) {
On 2016/08/29 10:29:09, Søren Gjesse wrote:
> Add explicit dynamic here?

done

https://codereview.chromium.org/2285803002/diff/100001/lib/src/datastore_impl...
lib/src/datastore_impl.dart:162: else if (value.entityValue != null)
On 2016/08/29 10:29:09, Søren Gjesse wrote:
> Why is value.nullValue not handled here?

It was handled via the default case below, but I've added it explicitly now.

https://codereview.chromium.org/2285803002/diff/100001/pubspec.yaml
File pubspec.yaml (right):

https://codereview.chromium.org/2285803002/diff/100001/pubspec.yaml#newcode14
pubspec.yaml:14: http_parser: '>=2.0.0 <3.0.0'
On 2016/08/29 15:59:24, kevmoo wrote:
> While you're at it: upgrade this to <4.0.0

Maybe I should make another commit for this ?)

Done.

[kustermann, 2016-08-29 16:24:09]

Description was changed from

==========
Upgrade to use stable `package:googleapis/v1.dart` of datastore


BUG=https://github.com/dart-lang/gcloud/issues/41
==========

to

==========
Upgrade to use stable `package:googleapis/v1.dart` of datastore


BUG=https://github.com/dart-lang/gcloud/issues/41
R=sgjesse@google.com, whesse@google.com

Committed:
https://github.com/dart-lang/gcloud/commit/8480c62531fb85389b44aa0364622cf357...
==========

[kustermann, 2016-08-29 16:24:10]

Committed patchset #5 (id:140001) manually as
8480c62531fb85389b44aa0364622cf357f29118 (presubmit successful).

[kustermann, 2016-08-29 16:25:06]

https://codereview.chromium.org/2285803002/diff/100001/CHANGELOG.md
File CHANGELOG.md (right):

https://codereview.chromium.org/2285803002/diff/100001/CHANGELOG.md#newcode1
CHANGELOG.md:1: ## 0.2.1
On 2016/08/29 10:29:09, Søren Gjesse wrote:
> Maybe bump this to 0.3.0? I know that the rules for 0.x.y are different.
However
> you could argue that the removal of the s~ prefix makes this a breaking change
-
> or is the s~ prefix still supported?

It's not supported, but the library is actually private: It's under **lib/src/**
(but people are using it and so I sort of agree I should update to 0.3.0)