Issue 22854022: Remove the transformless phase from AssetCascade.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22854022: Remove the transformless phase from AssetCascade. (Closed)

Created:
7 years, 4 months ago by nweiz

Modified:
7 years, 4 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove the transformless phase from AssetCascade. This is no longer necessary now that Phase tracks its outputs. R=rnystrom@google.com BUG=

Patch Set 1 #

Total comments: 2

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -43 lines)			Patch
	M	pkg/barback/lib/src/asset_cascade.dart	View		2 chunks	+3 lines, -7 lines	0 comments	Download
	M	pkg/barback/lib/src/phase.dart	View		7 chunks	+39 lines, -36 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Bob Nystrom

LGTM! https://codereview.chromium.org/22854022/diff/1/pkg/barback/lib/src/phase.dart File pkg/barback/lib/src/phase.dart (right): https://codereview.chromium.org/22854022/diff/1/pkg/barback/lib/src/phase.dart#newcode197 pkg/barback/lib/src/phase.dart:197: } Nit, but I think we generally put ...

7 years, 4 months ago (2013-08-19 20:46:36 UTC) #2

nweiz

https://codereview.chromium.org/22854022/diff/1/pkg/barback/lib/src/phase.dart File pkg/barback/lib/src/phase.dart (right): https://codereview.chromium.org/22854022/diff/1/pkg/barback/lib/src/phase.dart#newcode197 pkg/barback/lib/src/phase.dart:197: } On 2013/08/19 20:46:36, Bob Nystrom wrote: > Nit, ...

7 years, 4 months ago (2013-08-20 00:26:26 UTC) #3

nweiz

7 years, 4 months ago (2013-08-20 00:26:27 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r26332 (presubmit successful).

Expand Messages | Collapse Messages