Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(587)

Issue 22854016: Native subclasses of a mixin include classes extending native classes (Closed)

Created:
7 years, 4 months ago by sra1
Modified:
7 years, 4 months ago
Reviewers:
ngeoffray
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Native subclasses of a mixin include classes extending native classes Fixes a problem Pete found with mixins and custom elements. TBR=ngeoffray@google.com Committed: https://code.google.com/p/dart/source/detail?r=26251

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -15 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_backend/backend.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/ssa/interceptor_simplifier.dart View 1 chunk +1 line, -1 line 0 comments Download
A + tests/compiler/dart2js_native/subclassing_4_test.dart View 3 chunks +10 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sra1
Committed patchset #1 manually as r26251 (presubmit successful).
7 years, 4 months ago (2013-08-16 01:14:43 UTC) #1
ngeoffray
7 years, 4 months ago (2013-08-16 06:54:05 UTC) #2
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698