Issue 228533002: Fix assert in dart:math/Rectangle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228533002: Fix assert in dart:math/Rectangle. (Closed)

Created:
6 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 8 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix assert in dart:math/Rectangle. Didn't pass NaN down the correct path, and failed an assertion. Added tests. BUG= http://dartbug.com/17734 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=34822

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+73 lines, -4 lines)			Patch
	M	sdk/lib/math/rectangle.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	tests/lib/math/rectangle_test.dart	View		1 chunk	+69 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Lasse Reichstein Nielsen

6 years, 8 months ago (2014-04-08 13:12:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r34822 (presubmit successful).