Issue 22853009: For trigonometric functions call to C-libraries: they are faster than x87 operations (3% on Box2D).

Issue 22853009: For trigonometric functions call to C-libraries: they are faster than x87 operations (3% on Box2D). (Closed)

Created:
7 years, 4 months ago by srdjan

Modified:
7 years, 3 months ago

Reviewers:
zra, regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

For trigonometric functions call to C-libraries: they are faster than x87 operations (3% on Box2D). This also enables quicker trigonometrics on ARM and MIPS. TODO: Make InvokeMathCFunction more flexible so that it can handle both static and instance calls R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=27256

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+86 lines, -66 lines)			Patch
M	runtime/vm/flow_graph_compiler.h	View	1 2 3	1 chunk	+0 lines, -1 line	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	1 2 3	1 chunk	+0 lines, -6 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	1 2 3	1 chunk	+0 lines, -5 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	1 2 3	2 chunks	+7 lines, -10 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	1 2 3 4	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 2 3 4	1 chunk	+21 lines, -0 lines	0 comments	Download
M	runtime/vm/intermediate_language_arm.cc	View	1 2 3	2 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_ia32.cc	View	1 2 3	2 chunks	+15 lines, -14 lines	0 comments	Download
M	runtime/vm/intermediate_language_mips.cc	View	1 2 3	2 chunks	+11 lines, -1 line	0 comments	Download
M	runtime/vm/intermediate_language_x64.cc	View	1 2 3	2 chunks	+20 lines, -16 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #5 manually as r27256 (presubmit successful).

7 years, 3 months ago (2013-09-06 18:15:02 UTC) #3

regis

7 years, 3 months ago (2013-09-06 18:45:08 UTC) #4

Message was sent while issue was closed.

LGTM

https://codereview.chromium.org/22853009/diff/28001/runtime/vm/intermediate_l...
File runtime/vm/intermediate_language_x64.cc (right):

https://codereview.chromium.org/22853009/diff/28001/runtime/vm/intermediate_l...
runtime/vm/intermediate_language_x64.cc:3862: // TODO(vegorov): allow XMM0 to be
used.
For the same reason, we use Q7 instead of Q0 as TMP on ARM.

Expand Messages | Collapse Messages