Provide a way to get a Type back from a ClassMirror.

Provide a way to get a Type back from a ClassMirror.

BUG= http://dartbug.com/6433
R=asiva@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26407

[gbracha, 2013-08-16 19:59:31]

https://codereview.chromium.org/22849015/diff/4001/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/22849015/diff/4001/sdk/lib/mirrors/mirrors.da...
sdk/lib/mirrors/mirrors.dart:687: */
This will also have to account for remote mirrors eventually. So I'd modify the
comment:

"Returns true if this mirror reflects a non-generic class or an instantiated
generic class in the current isolate."

Also note the typo: "instanitated" ->  "instantiated"

[rmacnak, 2013-08-16 20:06:29]

https://codereview.chromium.org/22849015/diff/4001/sdk/lib/mirrors/mirrors.dart
File sdk/lib/mirrors/mirrors.dart (right):

https://codereview.chromium.org/22849015/diff/4001/sdk/lib/mirrors/mirrors.da...
sdk/lib/mirrors/mirrors.dart:687: */
On 2013/08/16 19:59:31, gbracha wrote:
> This will also have to account for remote mirrors eventually. So I'd modify
the
> comment:
> 
> "Returns true if this mirror reflects a non-generic class or an instantiated
> generic class in the current isolate."
> 
> Also note the typo: "instanitated" ->  "instantiated"
> 

Done.

[siva, 2013-08-19 21:15:43]

lgtm

https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors.cc
File runtime/lib/mirrors.cc (right):

https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors.cc#new...
runtime/lib/mirrors.cc:316: Instance::null_instance());
I think we should be using "Object::null_instance()" here and elsewhere
to be consistent. null_instance is a static method in class Object.

https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors_impl.dart
File runtime/lib/mirrors_impl.dart (right):

https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors_impl.d...
runtime/lib/mirrors_impl.dart:374: if (_reflectedType == null) {
if (!hasReflectedType) {
  ......
}

[rmacnak, 2013-08-20 20:44:35]

On 2013/08/19 21:15:43, siva wrote:
> lgtm
> 
> https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors.cc
> File runtime/lib/mirrors.cc (right):
> 
>
https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors.cc#new...
> runtime/lib/mirrors.cc:316: Instance::null_instance());
> I think we should be using "Object::null_instance()" here and elsewhere
> to be consistent. null_instance is a static method in class Object.

Done.

>
https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors_impl.dart
> File runtime/lib/mirrors_impl.dart (right):
> 
>
https://codereview.chromium.org/22849015/diff/8001/runtime/lib/mirrors_impl.d...
> runtime/lib/mirrors_impl.dart:374: if (_reflectedType == null) {
> if (!hasReflectedType) {
>   ......
> }

Done.

[rmacnak, 2013-08-20 23:05:40]

Committed patchset #4 manually as r26407 (presubmit successful).

[ahe, 2013-08-21 11:20:15]

Dart files, LGTM!

https://codereview.chromium.org/22849015/diff/17001/tests/lib/lib.status
File tests/lib/lib.status (right):

https://codereview.chromium.org/22849015/diff/17001/tests/lib/lib.status#newc...
tests/lib/lib.status:26: mirrors/reflected_type_test: Fail # Issue 6433
Wrong bug number. Either use 6490 or file a new dart2js bug.