TestCase times out after 20 seconds.

TestCase times out after 20 seconds.

R=gram@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26974

[ahe, 2013-08-16 17:01:36]

I spent a long time staring at a blank screen today.

In http://dartbug.com/12134, Ross Smith kindly shared this test:
https://github.com/rmsmith/ace.dart/blob/master/test/ace_test.dart

When compiling this test with dart2js and running it in Chrome, it simply hangs.

It turns out that the problem is this test:

@Test()
void testSetWrapLimitRange() {
  session.onChangeWrapMode.listen(expectAsync1((_) {    
    expect(session.wrapLimitRange['min'], equals(63));
    expect(session.wrapLimitRange['max'], equals(65));
  }));
  session.setWrapLimitRange(min: 63, max: 65);
}

For some reason, the expected event never fires, so 'expectAsync1' is never
called.

With my changes, this is now reported as:

  65 ERROR EditSession testSetWrapLimitRange. Test timed out after 20 seconds.

[gram, 2013-08-16 17:27:21]

lgtm! Thanks Peter.

[ahe, 2013-08-16 18:49:14]

PTAL (added the test).

[gram, 2013-08-16 19:11:19]

lgtm. I would suggest that instead of having a test that is marked as 'fail' in
the status file, this should be a proper unittest test that can make use of
shouldFail (that means it is independent of our internal test harness). However,
it would be faster for me to convert that than you as I'm more familiar with the
meta-test framework, so I think its fine to commit as is, but add a TODO with my
name saying "convert to a shouldFail passing test".

[ahe, 2013-08-31 09:25:04]

Committed patchset #4 manually as r26974 (presubmit successful).

[ahe, 2013-08-31 09:26:35]

On 2013/08/16 19:11:19, gram wrote:
> lgtm. I would suggest that instead of having a test that is marked as 'fail'
in
> the status file, this should be a proper unittest test that can make use of
> shouldFail (that means it is independent of our internal test harness).
However,
> it would be faster for me to convert that than you as I'm more familiar with
the
> meta-test framework, so I think its fine to commit as is, but add a TODO with
my
> name saying "convert to a shouldFail passing test".

Thank you, I did that and filed http://dartbug.com/12960 so we don't forget.