Issue 22849007: Enable unique global renaming in dart2dart minification.

Issue 22849007: Enable unique global renaming in dart2dart minification. (Closed)

Created:
7 years, 4 months ago by zarah

Modified:
7 years, 3 months ago

Reviewers:
ahe

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Enable unique global renaming in dart2dart minification. R=ahe@google.com Committed: https://code.google.com/p/dart/source/detail?r=26308

Patch Set 2 : Addressed review comments. #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+95 lines, -20 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/dart_backend/backend.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart	View	1	3 chunks	+30 lines, -19 lines	0 comments	Download
A	tests/compiler/dart2js/mirror_helper_unique_minification_test.dart	View		1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ahe

LGTM, but perhaps add a TODO about renaming local variables. https://codereview.chromium.org/22849007/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart (right): https://codereview.chromium.org/22849007/diff/1/sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart#newcode185 ...

7 years, 4 months ago (2013-08-16 18:39:26 UTC) #2

zarah

Committed patchset #2 manually as r26308 (presubmit successful).

7 years, 4 months ago (2013-08-19 07:56:14 UTC) #3

zarah

7 years, 3 months ago (2013-08-28 10:19:29 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/22849007/diff/1/sdk/lib/_internal/compiler/im...
File sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart
(right):

https://codereview.chromium.org/22849007/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:185:
if(uniqueGlobalNaming) {
On 2013/08/16 18:39:26, ahe wrote:
> Missing space after if.

Done.

https://codereview.chromium.org/22849007/diff/1/sdk/lib/_internal/compiler/im...
sdk/lib/_internal/compiler/implementation/dart_backend/renamer.dart:188: (ph) =>
allLocals.add(new Set<Node>()..addAll(ph.nodes)));
On 2013/08/16 18:39:26, ahe wrote:
> ph.nodes.toSet()?

Done.

Expand Messages | Collapse Messages