Issue 22842014: Fold equals and not equals comparisons for constant strings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22842014: Fold equals and not equals comparisons for constant strings. (Closed)

Created:
7 years, 3 months ago by Kevin Millikin (Google)

Modified:
7 years, 3 months ago

Reviewers:
Florian Schneider, srdjan

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fold equals and not equals comparisons for constant strings. BUG=https://code.google.com/p/dart/issues/detail?id=12530 R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=26645

Patch Set 1 #

Total comments: 1

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	runtime/vm/flow_graph_optimizer.cc	View		2 chunks	+8 lines, -2 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Committed patchset #1 manually as r26645 (presubmit successful).

7 years, 3 months ago (2013-08-26 12:37:28 UTC) #3

srdjan

7 years, 3 months ago (2013-08-26 16:00:38 UTC) #4

Message was sent while issue was closed.

DBC

https://codereview.chromium.org/22842014/diff/1/runtime/vm/flow_graph_optimiz...
File runtime/vm/flow_graph_optimizer.cc (right):

https://codereview.chromium.org/22842014/diff/1/runtime/vm/flow_graph_optimiz...
runtime/vm/flow_graph_optimizer.cc:6067: } else if (left.IsString() &&
right.IsString()) {
I believe all constant strings must be canonicalized, i.e., raw pointer
comparison should be enough.

Expand Messages | Collapse Messages