Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(476)

Issue 22835004: Remove -static from ldflags after precise upgrade (Closed)

Created:
7 years, 4 months ago by kustermann
Modified:
7 years, 4 months ago
Reviewers:
zra, Bill Hesse
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Remove -static from ldflags after precise upgrade R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=26055

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -11 lines) Patch
M samples/sample_extension/sample_extension.gyp View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/gyp/configurations_make.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
kustermann
7 years, 4 months ago (2013-08-13 09:31:19 UTC) #1
Bill Hesse
I'm not an expert on the ARM compilation, so I'll defer to zra. I see ...
7 years, 4 months ago (2013-08-13 10:23:15 UTC) #2
kustermann
On 2013/08/13 10:23:15, Bill Hesse wrote: > I'm not an expert on the ARM compilation, ...
7 years, 4 months ago (2013-08-13 10:54:57 UTC) #3
zra
lgtm
7 years, 4 months ago (2013-08-13 15:00:21 UTC) #4
kustermann
7 years, 4 months ago (2013-08-13 15:15:29 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r26055 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698