Issue 228323003: Comment out resolver tests to fix VM bot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 228323003: Comment out resolver tests to fix VM bot. (Closed)

Created:
6 years, 8 months ago by scheglov

Modified:
6 years, 8 months ago

Reviewers:
jwren, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Comment out resolver tests to fix VM bot. TBR R=jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=34895

Patch Set 1 #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -27 lines)			Patch
	M	pkg/analyzer/test/generated/resolver_test.dart	View		1 chunk	+27 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

scheglov

Committed patchset #1 manually as r34895 (presubmit successful).

6 years, 8 months ago (2014-04-09 20:47:10 UTC) #2

Brian Wilkerson

Why were these tests causing the VM bots to fail? Is there a plan for ...

6 years, 8 months ago (2014-04-10 22:14:37 UTC) #3

scheglov

6 years, 8 months ago (2014-04-10 22:18:30 UTC) #4

Message was sent while issue was closed.

On 2014/04/10 22:14:37, Brian Wilkerson wrote:
> Why were these tests causing the VM bots to fail?
> Is there a plan for fixing the problem?

Cannot find SDK on bot.
I just forgot to comment out what always was commented out.

Expand Messages | Collapse Messages