Issue 22831008: Added an introduction option by passing in a file with markdown.

Issue 22831008: Added an introduction option by passing in a file with markdown. (Closed)

Created:
7 years, 4 months ago by janicejl

Modified:
7 years, 4 months ago

Reviewers:
Emily Fortuna

CC:
Tate Mandel

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Added an introduction option by passing in a file with markdown. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=26213

Patch Set 4 : #

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -7 lines)			Patch
M	pkg/docgen/bin/docgen.dart	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
A	pkg/docgen/bin/sdk-introduction.md	View	1 2	1 chunk	+19 lines, -0 lines	0 comments	Download
M	pkg/docgen/lib/docgen.dart	View	1 2 3	5 chunks	+14 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Emily Fortuna

lgtm, one question, though https://codereview.chromium.org/22831008/diff/3001/pkg/docgen/lib/docgen.dart File pkg/docgen/lib/docgen.dart (right): https://codereview.chromium.org/22831008/diff/3001/pkg/docgen/lib/docgen.dart#newcode247 pkg/docgen/lib/docgen.dart:247: var intro = introduction == ...

7 years, 4 months ago (2013-08-15 18:39:35 UTC) #2

janicejl

PTAL. Added the sdk-introduction.md file. The content of the file was provided by Kathy. https://codereview.chromium.org/22831008/diff/3001/pkg/docgen/lib/docgen.dart ...

7 years, 4 months ago (2013-08-15 18:45:59 UTC) #3

janicejl

7 years, 4 months ago (2013-08-15 20:32:48 UTC) #5

Message was sent while issue was closed.

Committed patchset #4 manually as r26213 (presubmit successful).

Expand Messages | Collapse Messages