Issue 228293008: Redo "Construct literal maps using factory constructor."

Issue 228293008: Redo "Construct literal maps using factory constructor." (Closed)

Created:
6 years, 8 months ago by sra1

Modified:
6 years, 8 months ago

Reviewers:
Bill Hesse, floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Redo "Construct literal maps using factory constructor." TBR=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=34841

Patch Set 1 #

Patch Set 2 : add constructors to mock libraries for dart2js tests #

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+97 lines, -21 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View	1	5 chunks	+23 lines, -6 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/builder.dart	View	1	1 chunk	+49 lines, -7 lines	0 comments	Download
M	sdk/lib/_internal/lib/collection_patch.dart	View		2 chunks	+13 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/lib/js_helper.dart	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	tests/compiler/dart2js/dart_backend_test.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download
M	tests/language/language_dart2js.status	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	tests/utils/dummy_compiler_test.dart	View	1	1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sra1

Committed patchset #2 manually as r34841 (presubmit successful).

6 years, 8 months ago (2014-04-08 20:51:55 UTC) #1

Bill Hesse

6 years, 8 months ago (2014-04-08 23:07:51 UTC) #2

Message was sent while issue was closed.

There is a failure on dart2js linux ff 1 of 4 builder:

@@@BUILD_STEP dart2js-ff tests failures@@@

FAILED: dart2js-ff release_ia32 language/map_literal4_test
Expected: Pass 
Actual: RuntimeError
CommandOutput[dart2js]:
CommandOutput[ff]:

stdout:
events:
  [
        {
              type: debug
              value: test_controller.js started
              timestamp: 0
        },
        {
              type: debug
              value: Sending events to driver page (isFirstMessage = true,
isStatusUpdate = true, isDone = false)
              timestamp: 0.001
        },
        {
              type: print
              value: dart-calling-main
              timestamp: 0.018
        },
        {
              type: sync_exception
              value: Exception: Unsupported operation: Cannot modify
unmodifiable Map
                    Stack:
.wrapException@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:495
                   
.ConstantMap._throwUnmodifiable$0@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:826
                   
.ConstantMap.$indexSet@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:829
                   
J.$indexSet$a@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:1527
                   
.MapLiteral4Test.test$0@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:1435
                   
.main@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:1379
                   
dartMainRunner@http://127.0.0.1:43737/root_dart/tools/testing/dart/test_controller.js:288
                   
@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:1693
                   
@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:1675
                   
@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:1689
                   
@http://127.0.0.1:43737/root_build/generated_compilations/dart2js-sdk/tests_language_map_literal4_test/test.js:11

Expand Messages | Collapse Messages