Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Issue 22825009: Test that importing dart:core with a prefix does not hide dynamic. (Closed)

Created:
7 years, 4 months ago by rmacnak
Modified:
7 years, 4 months ago
Reviewers:
ahe, gbracha, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Test that importing dart:core with a prefix does not hide dynamic. BUG=http://dartbug.com/12478 R=ahe@google.com, gbracha@google.com Committed: https://code.google.com/p/dart/source/detail?r=26450

Patch Set 1 : #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
A tests/language/dynamic_prefix_core_test.dart View 1 1 chunk +17 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
7 years, 4 months ago (2013-08-15 01:23:22 UTC) #1
rmacnak
Separated test out to maintain existing coverage.
7 years, 4 months ago (2013-08-15 19:50:37 UTC) #2
ahe
LGTM!
7 years, 4 months ago (2013-08-15 19:53:29 UTC) #3
gbracha
lgtm
7 years, 4 months ago (2013-08-21 17:34:53 UTC) #4
gbracha
lgtm
7 years, 4 months ago (2013-08-21 17:34:55 UTC) #5
rmacnak
7 years, 4 months ago (2013-08-21 17:55:33 UTC) #6
Message was sent while issue was closed.
Committed patchset #4 manually as r26450 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698