Fix type warnings in declarer_test.

Fix type warnings in declarer_test.

There is still a warning before of 'expectAsync', but this would
require making it generic, which is outside of the scope of this CL.

R=brianwilkerson@google.com, rnystrom@google.com, nweiz@google.com
BUG=

Committed: https://github.com/dart-lang/test/commit/55024d3a346dbfac06635e8c5f5e87ce975ec8df

[Brian Wilkerson, 2016-08-26 17:36:14]

lgtm, but this isn't code I'm familiar with

[Bob Nystrom, 2016-08-26 18:04:42]

LGTM!

[scheglov, 2016-08-26 18:41:10]

Description was changed from

==========
Fix type warnings in declarer_test.

There is still a warning before of 'expectAsync', but this would
require making it generic, which is outside of the scope of this CL.

R=nweiz@google.com,rnystrom@google.com,brianwilkerson@google.com
BUG=
==========

to

==========
Fix type warnings in declarer_test.

There is still a warning before of 'expectAsync', but this would
require making it generic, which is outside of the scope of this CL.

R=brianwilkerson@google.com, rnystrom@google.com, nweiz@google.com
BUG=

Committed:
https://github.com/dart-lang/test/commit/55024d3a346dbfac06635e8c5f5e87ce975e...
==========

[scheglov, 2016-08-26 18:41:11]

Committed patchset #1 (id:1) manually as
55024d3a346dbfac06635e8c5f5e87ce975ec8df (presubmit successful).

[nweiz, 2016-08-26 20:22:38]

What's the goal of this? In general, we don't keep test tests strong-mode clean,
in part because the use of expectAsync() makes that impossible currently. We
also don't need to run them through DDC. I don't see a lot of value in
selectively making a single test partially strong-mode clean, especially since
we have no process for ensuring that new errors and warnings aren't added in the
future.

[scheglov, 2016-08-26 20:26:29]

On 2016/08/26 20:22:38, nweiz wrote:
> What's the goal of this? In general, we don't keep test tests strong-mode
clean,
> in part because the use of expectAsync() makes that impossible currently. We
> also don't need to run them through DDC. I don't see a lot of value in
> selectively making a single test partially strong-mode clean, especially since
> we have no process for ensuring that new errors and warnings aren't added in
the
> future.

Just general hygiene, the boy scout rule, etc.

"The process" could be as simple is looking into the Dart Analysis view of your
IDEA and making sure that it is empty :-)

[nweiz, 2016-08-26 20:31:21]

On 2016/08/26 20:26:29, scheglov wrote:
> On 2016/08/26 20:22:38, nweiz wrote:
> > What's the goal of this? In general, we don't keep test tests strong-mode
> clean,
> > in part because the use of expectAsync() makes that impossible currently. We
> > also don't need to run them through DDC. I don't see a lot of value in
> > selectively making a single test partially strong-mode clean, especially
since
> > we have no process for ensuring that new errors and warnings aren't added in
> the
> > future.
> 
> Just general hygiene, the boy scout rule, etc.
> 
> "The process" could be as simple is looking into the Dart Analysis view of
your
> IDEA and making sure that it is empty :-)

But it can't be empty—expectAsync() is currently not strong-mode compatible, nor
is it possible to make it compatible (see
https://github.com/dart-lang/test/issues/436).

Also I don't use an IDE ;-).

[scheglov, 2016-08-26 22:19:59]

On 2016/08/26 20:31:21, nweiz wrote:
> On 2016/08/26 20:26:29, scheglov wrote:
> > On 2016/08/26 20:22:38, nweiz wrote:
> > > What's the goal of this? In general, we don't keep test tests strong-mode
> > clean,
> > > in part because the use of expectAsync() makes that impossible currently.
We
> > > also don't need to run them through DDC. I don't see a lot of value in
> > > selectively making a single test partially strong-mode clean, especially
> since
> > > we have no process for ensuring that new errors and warnings aren't added
in
> > the
> > > future.
> > 
> > Just general hygiene, the boy scout rule, etc.
> > 
> > "The process" could be as simple is looking into the Dart Analysis view of
> your
> > IDEA and making sure that it is empty :-)
> 
> But it can't be empty—expectAsync() is currently not strong-mode compatible,
nor
> is it possible to make it compatible (see
> https://github.com/dart-lang/test/issues/436).
> 
> Also I don't use an IDE ;-).


Well, we should strive to have zero errors / warnings / hints / lints.
But IMHO it is good to have less even if we cannot get zero.

[Bob Nystrom, 2016-08-29 21:11:06]

On 2016/08/26 22:19:59, scheglov wrote:
> Well, we should strive to have zero errors / warnings / hints / lints.
> But IMHO it is good to have less even if we cannot get zero.

+1.

We will need to get to zero eventually, and I don't expect to do that in one
giant monolithic CL, so patches like this are helpful.