dart:io | Add badCertificateCallback to HttpClient.

dart:io | Add badCertificateCallback to HttpClient.

BUG=dartbug.com/9689
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=26110

[Søren Gjesse, 2013-08-13 16:56:08]

lgtm

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart#newcode1181
sdk/lib/io/http.dart:1181: * If the callback returns true, the future completes
"the future" - please be more specific to what future that is (HttpClient.open
and friends I assume).

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart#newcode1182
sdk/lib/io/http.dart:1182: * with an HttpRequest object.  Otherwise, the future
completes with an error.
Maybe mention explicitly that "otherwise" includes the calback throwing.

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart#newcode1184
sdk/lib/io/http.dart:1184: * Each [open] or [get] call uses the value of
badCertificateCallback
We have all of open, openUrl, get, getUrl, port, postUrl, but I don't think we
are normally mentioning all of them...

[Bill Hesse, 2013-08-14 09:25:48]

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart#newcode1181
sdk/lib/io/http.dart:1181: * If the callback returns true, the future completes
On 2013/08/13 16:56:08, Søren Gjesse wrote:
> "the future" - please be more specific to what future that is (HttpClient.open
> and friends I assume).

Done.

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart#newcode1182
sdk/lib/io/http.dart:1182: * with an HttpRequest object.  Otherwise, the future
completes with an error.
On 2013/08/13 16:56:08, Søren Gjesse wrote:
> Maybe mention explicitly that "otherwise" includes the calback throwing.

Done.

https://codereview.chromium.org/22816008/diff/1/sdk/lib/io/http.dart#newcode1184
sdk/lib/io/http.dart:1184: * Each [open] or [get] call uses the value of
badCertificateCallback
On 2013/08/13 16:56:08, Søren Gjesse wrote:
> We have all of open, openUrl, get, getUrl, port, postUrl, but I don't think we
> are normally mentioning all of them...

Done.

[Bill Hesse, 2013-08-14 09:26:08]

Committed patchset #2 manually as r26110 (presubmit successful).