Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 228023004: Revert "Add support for closure calls through getters." (Closed)

Created:
6 years, 8 months ago by floitsch
Modified:
6 years, 8 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Add support for closure calls through getters." This reverts commit r34818. Committed: https://code.google.com/p/dart/source/detail?r=34820

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+127 lines, -267 lines) Patch
M sdk/lib/_internal/compiler/implementation/js_emitter/reflection_data_parser.dart View 1 chunk +1 line, -2 lines 0 comments Download
M sdk/lib/_internal/lib/js_helper.dart View 4 chunks +2 lines, -5 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 10 chunks +83 lines, -170 lines 0 comments Download
M tests/lib/lib.status View 2 chunks +5 lines, -8 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_previously_accessed_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_getter_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/invoke_call_through_implicit_getter_previously_accessed_test.dart View 3 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/invoke_closurization_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
D tests/lib/mirrors/mirrors_nsm_test.dart View 1 chunk +0 lines, -46 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
floitsch
TBR. There seems to be a test that I don't run locally :(
6 years, 8 months ago (2014-04-08 13:05:58 UTC) #1
floitsch
6 years, 8 months ago (2014-04-08 13:06:29 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r34820 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698