Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 228013003: Use mirrors and annotations to find test methods. (Closed)

Created:
6 years, 8 months ago by scheglov
Modified:
6 years, 8 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use mirrors and annotations to find test methods. It was too tiresome to type test method names three times, jumping back and forth between test class and main earlier this morning. :-) Also, we had a discussion about tests in the office. R=brianwilkerson@google.com, danrubel@google.com, pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=35067

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -42 lines) Patch
A pkg/analysis_server/test/declarative_tests.dart View 1 chunk +51 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/protocol_test.dart View 23 chunks +40 lines, -42 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
6 years, 8 months ago (2014-04-08 04:02:12 UTC) #1
Brian Wilkerson
LGTM, but I'd like to hear the conversation and might want to modify this afterward. ...
6 years, 8 months ago (2014-04-08 04:44:25 UTC) #2
scheglov
On 2014/04/08 04:44:25, Brian Wilkerson wrote: > LGTM, but I'd like to hear the conversation ...
6 years, 8 months ago (2014-04-08 04:54:54 UTC) #3
scheglov
6 years, 8 months ago (2014-04-15 16:34:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r35067 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698